Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify encoding to not output "i":null in JSON #1260

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jwiegley
Copy link
Contributor

PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • Documentation has been updated if new natives or FV properties have been added. To generate new documentation, issue cabal run tests. If they pass locally, docs are generated.
  • Any changes that could be relevant to users have been recorded in the changelog
  • In case of changes to the Pact trace output (pact -t), make sure pact-lsp is in sync.

Additionally, please justify why you should or should not do the following:

  • Confirm replay/back compat
  • Benchmark regressions
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact

@jwiegley
Copy link
Contributor Author

jwiegley commented Jul 25, 2023

This change currently breaks 3 golden tests that depend on a particular hash of the txlogs. I just need to verify that the test simply needs to be updated.

@jwiegley jwiegley marked this pull request as ready for review August 21, 2023 23:47
@rsoeldner
Copy link
Member

@jwiegley Where is this encoding being used, does it have to be forked?

@jwiegley
Copy link
Contributor Author

@rsoeldner Yes, it will need a fork. It is used anywhere that Pact is serialized, such as modules in the db.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants