Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some linting #1198

Merged
merged 3 commits into from
Apr 19, 2023
Merged

some linting #1198

merged 3 commits into from
Apr 19, 2023

Conversation

larskuhtz
Copy link
Contributor

No description provided.

Copy link
Contributor

@jwiegley jwiegley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all seem like harmless changes, if it passes CI then I approve.

src/Pact/Compile.hs Outdated Show resolved Hide resolved
Copy link
Member

@jmcardon jmcardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but also prefer traverse over mapM

Co-authored-by: Edmund Noble <edmundnoble@users.noreply.github.com>
@larskuhtz larskuhtz merged commit 126d684 into master Apr 19, 2023
@larskuhtz larskuhtz deleted the lars/misc branch April 19, 2023 17:47
@jwiegley
Copy link
Contributor

traverse does have a more general feel to it...

jwiegley pushed a commit that referenced this pull request Apr 26, 2023
* some linting

* Update src/Pact/Compile.hs

Co-authored-by: Edmund Noble <edmundnoble@users.noreply.github.com>

---------

Co-authored-by: Edmund Noble <edmundnoble@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants