Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix with-read desugaring to use pattern guard #281

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Fix with-read desugaring to use pattern guard #281

merged 2 commits into from
Nov 18, 2024

Conversation

jmcardon
Copy link
Member

PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • (If Relevant) Documentation has been (manually) updated at https://docs.kadena.io/pact

Additionally, please justify why you should or should not do the following:

  • Benchmark regressions
  • Confirm replay/back compat (Ignore until core release)
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact (Ignore until core release)

rsoeldner
rsoeldner previously approved these changes Nov 14, 2024
View reviewed changes
rsoeldner
rsoeldner reviewed Nov 18, 2024
View reviewed changes
pact-repl/Pact/Core/IR/Eval/Direct/CoreBuiltin.hs
where
sortPv (PLiteral l) (PLiteral y) = l `compare` y
sortPv (PTime t) (PTime t') = t `compare` t'
sortPv _ _ = EQ
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, do you have any justification why this is correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See: Prod sorting

@rsoeldner rsoeldner dismissed their stale review November 18, 2024 09:50

additional changes

@jmcardon jmcardon merged commit b3778e7 into master Nov 18, 2024
11 checks passed
@jmcardon jmcardon deleted the jose/parity-err-fixes branch November 18, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsoeldner rsoeldner rsoeldner approved these changes

@jwiegley jwiegley Awaiting requested review from jwiegley jwiegley is a code owner

@emilypi emilypi Awaiting requested review from emilypi emilypi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcardon @rsoeldner