Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas tweaks for mainnet release #250

Merged
merged 9 commits into from
Oct 14, 2024
Merged

Gas tweaks for mainnet release #250

merged 9 commits into from
Oct 14, 2024

Conversation

jmcardon
Copy link
Member

@jmcardon jmcardon commented Oct 9, 2024

  • Gas Adjustments to pow, shift, sort
  • Gas Adjustments to typechecking.
  • Changed Gas to SatWord for safer gas charging

PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • (If Relevant) Documentation has been (manually) updated at https://docs.kadena.io/pact

Additionally, please justify why you should or should not do the following:

  • Benchmark regressions
    We're actually faster
benchmarking Pact Core Benchmarks/Pure Code/Factorial 1000
time                 157.5 μs   (157.3 μs .. 157.9 μs)
                     1.000 R²   (1.000 R² .. 1.000 R²)
mean                 157.8 μs   (157.5 μs .. 158.2 μs)
std dev              1.039 μs   (660.0 ns .. 1.557 μs)

benchmarking Pact Core Benchmarks/Pure Code/Let 100
time                 23.25 μs   (22.87 μs .. 23.69 μs)
                     0.995 R²   (0.986 R² .. 0.999 R²)
mean                 23.53 μs   (22.92 μs .. 25.19 μs)
std dev              2.173 μs   (532.9 ns .. 4.068 μs)
variance introduced by outliers: 80% (severely inflated)

benchmarking Pact Core Benchmarks/Pure Code/Let 1000
time                 241.5 μs   (238.9 μs .. 244.2 μs)
                     0.999 R²   (0.999 R² .. 1.000 R²)
mean                 242.5 μs   (240.2 μs .. 244.7 μs)
std dev              4.845 μs   (3.723 μs .. 6.369 μs)
variance introduced by outliers: 10% (moderately inflated)


  • Confirm replay/back compat (Ignore until core release)
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact (Ignore until core release)

@jmcardon jmcardon mentioned this pull request Oct 9, 2024
6 tasks
- Gas Adjustments to pow, shift, sort
- Gas Adjustments to typechecking.
- Changed Gas to `SatWord` for safer gas charging
@@ -9,7 +9,7 @@
=: 1026
>: 114
>=: 114
^: 5000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lower ? 😢

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is much more accurate now

@jmcardon jmcardon merged commit 9a9df75 into master Oct 14, 2024
11 checks passed
@jmcardon jmcardon deleted the jose/gas-changes branch October 14, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants