Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge master into pact5 #2052

Merged
merged 10 commits into from
Nov 28, 2024
Merged

merge master into pact5 #2052

merged 10 commits into from
Nov 28, 2024

Conversation

larskuhtz
Copy link
Contributor

No description provided.

edmundnoble and others added 9 commits November 18, 2024 21:15
@edmundnoble
randomized peer ordering
a1198fc 
We randomize the peer ordering by assigning a peer a random number
that is used subsequently to order it with respect to other peers upon
request from the /peer GET endpoint.

An alternative of generating a seed on startup that would be used to
"salt" the peer ordering was considered but ran into implementation
difficulties and seems equivalent.
@chessai @edmundnoble
make cwtool its own component; split all executables into their own.
0cf12a2 
Change-Id: Ib1ee24d78c2b09e7687285e1b229e1996a214afa
@chessai @edmundnoble
fix ea call in macos ci
d03dfa6
@chessai
add error messages for assertCommand failures in pact api
bd5d6af 
Change-Id: Ifbad9a2e9c28810f34b80a6c02cc08d68c955cff
@chessai
sendHandler: include position of first command to fail
1038f75 
Change-Id: Ife3bc9380cce0fd1ea568e8fe40a1aed903c5643
@chessai
remove redundant $ in test lib
d80eaf4 
Change-Id: I796db312622794cb7a8ab8679a2297859a682bbc
@chessai
add remote pact test for send error messages
de0b85b 
Change-Id: I2046ab2a28a2951c71ef4909e580e51256673716
@larskuhtz
remove redundant sbv pin from cabal.project
8d00677
@larskuhtz
Merge branch 'master' into lars/merge-master-into-pact5
8aedac3
@larskuhtz larskuhtz requested review from edmundnoble and chessai and removed request for edmundnoble November 27, 2024 23:25
@larskuhtz
Copy link
Contributor Author

Currently this unit test fails:

Chainweb Tests
  Tests starting nodes
    Chainweb.Test.Pact4.RemotePactTest
      invalid command test:                                                                                    FAIL (1.41s)
        test/unit/Chainweb/Test/Pact4/RemotePactTest.hs:223:
        Predicate failed, responseBody was: Validation failed for hash "qY9CTPIo_sBhq7umt4hEk3dGNbmC_spwcnmvpTsv2tM": Pact parse error: Failed reading: mzero
        Use -p '!/chainweb216Test/&&/invalid command test/' to rerun this test only.

@larskuhtz
Copy link
Contributor Author

@chessai I had to adjust the expected outputs in the command validation tests test/unit/Chainweb/Test/Pact4/RemotePactTest.hs (cf. commit 7101176).

The new failure messages are little less informative. Can you please take a look and double check that this is intended for the pact5 branch and not a merge bug.

@edmundnoble edmundnoble merged commit ad3cf8d into pact5 Nov 28, 2024
40 of 41 checks passed
@edmundnoble edmundnoble deleted the lars/merge-master-into-pact5 branch November 28, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chessai chessai chessai approved these changes

@edmundnoble edmundnoble edmundnoble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@larskuhtz @edmundnoble @chessai