Allow building with GHC 9.6 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While maintaining the build with the old package set, which is still needed by obelisk projects, like block-explorer
|
I've pinned the |
enobayram
added a commit
that referenced
this pull request
Dec 18, 2023
This PR fixes a regression introduced by #52. The rewrite of the `FromJSON` instance in that PR changed the behavior when the `exec` field doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows us to compile
chainweb-apiwith the latest GHC versions while maintaining the build with the old package set, which is still needed by obelisk projects, like block-explorer.In order to maintain the build with the old dependency tree alongside the latest packages from hackage, we had to tiptoe around the following breaking changes:
aesondoesn't represent itsObjects asHashMaps anymore, so this PR rewrites JSON parsing code to not depend on that representation.aesonnow hides theTextrepresentation of its objectKeys, so we're now going fromTexttoStringand then coming back withfromString, which lets the result work with both representations.base16-bytestringchanged the type of itsdecodefunction fromdecode :: ByteString -> (ByteString, ByteString)toByteString -> Either String ByteString, which we had to work around by resorting toCPP.