Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an experimental --dry-run #588

Merged
merged 13 commits into from
Nov 9, 2023
Merged

Add an experimental --dry-run #588

merged 13 commits into from
Nov 9, 2023

Commits on Nov 6, 2023

  1. Reorder apply phases 

    Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
    @kke
    kke committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    d33fa10 View commit details
    Browse the repository at this point in the history

  2. Build all k0s configs already in Prepare() 

    Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
    @kke
    kke committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    808b559 View commit details
    Browse the repository at this point in the history

  3. Rename UploadBinaries to UploadK0s 

    Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
    @kke
    kke committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    f464b99 View commit details
    Browse the repository at this point in the history

  4. Add reset conditionals to several phases 

    Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
    @kke
    kke committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    2a9dbc7 View commit details
    Browse the repository at this point in the history

  5. Fix env cleanup on reset phases 

    Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
    @kke
    kke committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    0c9c03b View commit details
    Browse the repository at this point in the history

  6. Inline LeaveEtcd 

    Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
    @kke
    kke committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    abd601a View commit details
    Browse the repository at this point in the history

  7. Add manager.Wet() 

    Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
    @kke
    kke committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    a30179a View commit details
    Browse the repository at this point in the history

  8. Replace the PathFuncs interface magic with a plain map 

    The strange interface magic done in configurers to allow overriding the
path functions is something I never quite understood how it actually
works and why it is necessary. Here the mechanism is replaced with a
simple map[string]string and getter functions + a setter because in the
dry-run mechanism it was necessary to programmatically override the
K0sBinaryPath() at run time.

Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
    @kke
    kke committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    a358bef View commit details
    Browse the repository at this point in the history

  9. Implement dry run in phases 

    Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
    @kke
    kke committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    84fdb53 View commit details
    Browse the repository at this point in the history

  10. Upgrade smoke was broken 

    Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
    @kke
    kke committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    d31c52d View commit details
    Browse the repository at this point in the history

  11. Mark dry-run flag experimental 

    Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
    @kke
    kke committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    1cc4d94 View commit details
    Browse the repository at this point in the history

  12. Clean up workflows 

    Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
    @kke
    kke committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    b1c5de7 View commit details
    Browse the repository at this point in the history

  13. Add a dry-run smoke-test 

    Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
    @kke
    kke committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    4699fc3 View commit details
    Browse the repository at this point in the history