Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional insertAt options, add support for postprocessors to templated prompts #68
Additional insertAt options, add support for postprocessors to templated prompts #68
Changes from all commits
ab57716
b5b6006
8f784d9
6b23999
6c8c2a8
d038dcf
1488c4e
8179126
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well-implemented function with clear documentation.
The
indentOneLevel
function is well-documented and logically structured. It effectively uses regular expressions and string manipulation to indent lines based on the maximum indentation of two reference lines.Suggestion for Improvement:
Consider adding error handling for potential edge cases, such as
null
orundefined
inputs, to enhance robustness.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logical extension of text selection functionality.
The
getSelectedTextOrNote
function effectively extends thegetSelectedText
function by adding the capability to determine if the entire note is selected. This is useful for features that need to differentiate between partial and full note selections.Suggestion for Improvement:
Consider simplifying the condition for
isWholeNote
to enhance readability and maintainability.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Efficient function for calculating line numbers.
The
getLineNumberAtPos
function is well-implemented and efficiently calculates the line number corresponding to a given position in the text. This function is crucial for features that need to manipulate text based on line numbers.Suggestion for Improvement:
Consider optimizing the loop to reduce the number of iterations for large texts, potentially using a binary search approach if the lines are of relatively uniform length.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Useful functions for navigating text based on position.
The
getLineBefore
andgetLineAfter
functions effectively leveragegetLineNumberAtPos
andgetLine
to retrieve the lines before and after a specific position. These functions are crucial for features that need to navigate text based on its position within the editor.Suggestion for Improvement:
Consider adding error handling for cases where the position is at the start or end of the text to prevent potential out-of-range errors.