Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional file extensions for HEIC/HEIF #723

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

jdpurcell
Copy link
Contributor

Fixes #702. Added .hif extension which is non-standard but used by Canon cameras. I found a sample image here and was able to load it.

Also added .heics/.heifs which are "sequence" variants (i.e. animated); we can at least display them as stills but the decoders don't support animation. I found some sample .heics files which the iPhone apparently produces for its "Live Stickers" feature.

@jdpurcell
Copy link
Contributor Author

I did some code cleanup as well, and the #ifdef is related to qt/qtbase@44a17e9.

@@ -87,7 +85,6 @@ class QVApplication : public QApplication

QMenuBar *menuBar;

QStringList filterList;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing was even using this 😋

@jurplel jurplel merged commit 0114aa0 into jurplel:master Oct 17, 2024
7 checks passed
@jdpurcell jdpurcell deleted the pr-hifext branch October 18, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support heif file extension on mac.
2 participants