Add config flag to disable online update check #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a compile time flag for disabling update checks in qView as requested by #631.
Update checks are disabled either by uncommenting the line
CONFIG += qv_disable_online_version_checkin qView.pro or the option can also be specified when compiling from the command line like this:
qmake "CONFIG+=qv_disable_online_version_check" ../qView/qView.proWhen this flag is present, checking for updates is completely removed from qView because the
UpdateCheckerclass source files are not included in the project. A few macros are then used to remove references and calls ofUpdateChecker. Settings and information labels that have to do with updates are hidden as well.When the flag is not added, the program compiles and functions without any changes.
I tested this on Windows 10 and Kubuntu 22.04.
Here are some screenshots of hidden labels and checkboxes: