Theories: only get all data points from enum and boolean types if the… #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re is no @FromDataPoints annotation, or the named data points represent a non-empty set of the same type. Fixes junit-team#1648
stefanbirkner
approved these changes
Apr 19, 2020
|
Not familiar with the pull request flow. Do I now have to do something to merge this, or is that something somebody on the project will do? |
stefanbirkner
previously approved these changes
Apr 21, 2020
src/main/java/org/junit/experimental/theories/internal/Assignments.java
Outdated
Show resolved
Hide resolved
|
The JUnit team will merge it when two of us have approved the PR. |
…ents.java Co-Authored-By: Stefan Birkner <github@stefan-birkner.de>
awturner
commented
Apr 21, 2020
src/main/java/org/junit/experimental/theories/internal/Assignments.java
Outdated
Show resolved
Hide resolved
marcphilipp
reviewed
Apr 21, 2020
| } else if (paramType.equals(Boolean.class) || paramType.equals(boolean.class)) { | ||
| return new BooleanSupplier().getValueSources(unassigned); | ||
|
|
||
| FromDataPoints fromDataPoints = unassigned.getAnnotation(FromDataPoints.class); |
There was a problem hiding this comment.
❓ Shouldn't this check for ParametersSuppliedBy or, alternatively, shouldn't SpecificDataPointsSupplier throw an exception if it couldn't find a matching field?
stefanbirkner
dismissed
their stale review
I agree with @marcphilipp that it should be part of SpecificDataPointsSupplier
|
Then please can you fix this yourselves? Sorry, I just don't have enough knowledge of the code base. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…re is no @FromDataPoints annotation, or the named data points represent a non-empty set of the same type.
Fixes #1648