Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize Rack dependency and tests #27

Merged
merged 27 commits into from
Nov 11, 2024
Merged

Harmonize Rack dependency and tests #27

merged 27 commits into from
Nov 11, 2024

Commits on Nov 4, 2024

  1. Configuration menu
    Copy the full SHA
    e8c22f4 View commit details
    Browse the repository at this point in the history
  2. Use Rack::Lint in the test suite (#24)

    Since rack 3 is now supported by Rails, it seems important to ensure that this middleware has a proper support for it. Issues with rack 3 are difficult to notice or debug. To help prevent issues with compatibility and the time that it takes to manually debug and resolve those - I suggest that we integrate `Rack::Lint` into the test suite.
    
    Rack::Lint would ensure that middleware adheres to the SPEC.
    
    Please be patient, since I' still figuring out how this works ;-)
    
    Related documentation (for me to read through multiple times):
    - https://github.com/rack/rack/blob/744f92d099653f873ced3380e425a6f82f0c6c6c/UPGRADE-GUIDE.md?plain=1#L185
    - https://github.com/rack/rack/blob/744f92d099653f873ced3380e425a6f82f0c6c6c/SPEC.rdoc
    
    ---------
    
    Co-authored-by: Julik Tarkhanov <me@julik.nl>
    skatkov and julik authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    339aeea View commit details
    Browse the repository at this point in the history
  3. Add tests for fingerprinting

    Make sure fingerprinting works with non-rewindable request bodies, and add tests to make sure everything contributes to the fingerprint correctly
    julik committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    06d18c4 View commit details
    Browse the repository at this point in the history
  4. Do not check for Rack versions

    Something that supports to_ary "just" supports it anyway
    julik committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    f93b042 View commit details
    Browse the repository at this point in the history
  5. Start fixing all the lint-non-compliances

    as there are quite a few
    julik committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    000baff View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    54d9e71 View commit details
    Browse the repository at this point in the history
  7. More clarity is better

    julik committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    0f4455d View commit details
    Browse the repository at this point in the history
  8. Remove body-rewinding spec

    as it doesn't make much sense with Rack 3.0 streaming bodies - we may be able to read out the request body, or we may not be able to. If we are not able - the fingerprint will be the same.
    julik committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    6625829 View commit details
    Browse the repository at this point in the history
  9. With a HEAD request there is no body

    as Lint is appropriately hinting
    julik committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    c6e3667 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    aa3c043 View commit details
    Browse the repository at this point in the history
  11. Somewhat closer

    julik committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    a6a9e21 View commit details
    Browse the repository at this point in the history
  12. No need to test on Ruby 3

    because if it works on 2.7 it will work on 3 just as well, and we are not using 3.x specific syntax (and have standardrb rules configured accordingly)
    julik committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    ac4f5c1 View commit details
    Browse the repository at this point in the history
  13. Lint

    julik committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    6c2cc9f View commit details
    Browse the repository at this point in the history
  14. And the last one

    julik committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    4eb7f33 View commit details
    Browse the repository at this point in the history
  15. Regenerate gemfiles

    julik committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    edff458 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Configuration menu
    Copy the full SHA
    6146ba8 View commit details
    Browse the repository at this point in the history
  2. Install all the things

    julik committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    8f4bd77 View commit details
    Browse the repository at this point in the history
  3. meh

    julik committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    d17f3e5 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Configuration menu
    Copy the full SHA
    efc4640 View commit details
    Browse the repository at this point in the history
  2. Use the body size

    julik committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    bf2c344 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5e5eaa4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a8dd3ae View commit details
    Browse the repository at this point in the history
  5. And that

    julik committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    8ce50b9 View commit details
    Browse the repository at this point in the history
  6. Better name

    julik committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    6f03877 View commit details
    Browse the repository at this point in the history
  7. Bump version and changelog

    julik committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    f48b994 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2024

  1. Configuration menu
    Copy the full SHA
    d1f4462 View commit details
    Browse the repository at this point in the history
  2. Tweak versions

    julik committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    808b808 View commit details
    Browse the repository at this point in the history