-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmonize Rack dependency and tests #27
Merged
Merged
Commits on Nov 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e8c22f4 - Browse repository at this point
Copy the full SHA e8c22f4View commit details -
Use Rack::Lint in the test suite (#24)
Since rack 3 is now supported by Rails, it seems important to ensure that this middleware has a proper support for it. Issues with rack 3 are difficult to notice or debug. To help prevent issues with compatibility and the time that it takes to manually debug and resolve those - I suggest that we integrate `Rack::Lint` into the test suite. Rack::Lint would ensure that middleware adheres to the SPEC. Please be patient, since I' still figuring out how this works ;-) Related documentation (for me to read through multiple times): - https://github.com/rack/rack/blob/744f92d099653f873ced3380e425a6f82f0c6c6c/UPGRADE-GUIDE.md?plain=1#L185 - https://github.com/rack/rack/blob/744f92d099653f873ced3380e425a6f82f0c6c6c/SPEC.rdoc --------- Co-authored-by: Julik Tarkhanov <me@julik.nl>
Configuration menu - View commit details
-
Copy full SHA for 339aeea - Browse repository at this point
Copy the full SHA 339aeeaView commit details -
Make sure fingerprinting works with non-rewindable request bodies, and add tests to make sure everything contributes to the fingerprint correctly
Configuration menu - View commit details
-
Copy full SHA for 06d18c4 - Browse repository at this point
Copy the full SHA 06d18c4View commit details -
Do not check for Rack versions
Something that supports to_ary "just" supports it anyway
Configuration menu - View commit details
-
Copy full SHA for f93b042 - Browse repository at this point
Copy the full SHA f93b042View commit details -
Configuration menu - View commit details
-
Copy full SHA for 000baff - Browse repository at this point
Copy the full SHA 000baffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 54d9e71 - Browse repository at this point
Copy the full SHA 54d9e71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f4455d - Browse repository at this point
Copy the full SHA 0f4455dView commit details -
as it doesn't make much sense with Rack 3.0 streaming bodies - we may be able to read out the request body, or we may not be able to. If we are not able - the fingerprint will be the same.
Configuration menu - View commit details
-
Copy full SHA for 6625829 - Browse repository at this point
Copy the full SHA 6625829View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6e3667 - Browse repository at this point
Copy the full SHA c6e3667View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa3c043 - Browse repository at this point
Copy the full SHA aa3c043View commit details -
Configuration menu - View commit details
-
Copy full SHA for a6a9e21 - Browse repository at this point
Copy the full SHA a6a9e21View commit details -
because if it works on 2.7 it will work on 3 just as well, and we are not using 3.x specific syntax (and have standardrb rules configured accordingly)
Configuration menu - View commit details
-
Copy full SHA for ac4f5c1 - Browse repository at this point
Copy the full SHA ac4f5c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c2cc9f - Browse repository at this point
Copy the full SHA 6c2cc9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4eb7f33 - Browse repository at this point
Copy the full SHA 4eb7f33View commit details -
Configuration menu - View commit details
-
Copy full SHA for edff458 - Browse repository at this point
Copy the full SHA edff458View commit details
Commits on Nov 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6146ba8 - Browse repository at this point
Copy the full SHA 6146ba8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f4bd77 - Browse repository at this point
Copy the full SHA 8f4bd77View commit details -
Configuration menu - View commit details
-
Copy full SHA for d17f3e5 - Browse repository at this point
Copy the full SHA d17f3e5View commit details
Commits on Nov 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for efc4640 - Browse repository at this point
Copy the full SHA efc4640View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf2c344 - Browse repository at this point
Copy the full SHA bf2c344View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e5eaa4 - Browse repository at this point
Copy the full SHA 5e5eaa4View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8dd3ae - Browse repository at this point
Copy the full SHA a8dd3aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ce50b9 - Browse repository at this point
Copy the full SHA 8ce50b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f03877 - Browse repository at this point
Copy the full SHA 6f03877View commit details -
Configuration menu - View commit details
-
Copy full SHA for f48b994 - Browse repository at this point
Copy the full SHA f48b994View commit details
Commits on Nov 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d1f4462 - Browse repository at this point
Copy the full SHA d1f4462View commit details -
Configuration menu - View commit details
-
Copy full SHA for 808b808 - Browse repository at this point
Copy the full SHA 808b808View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.