Widescreen: Avoid clipping world Y position for FIELD mode world script movements #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait, it seems there is another scene that has to be tested |
|
The scene seems fine. |
julianxhokaxhiu
added
bug
tangtang95
force-pushed
the
bugfix/widescreen-chocobo-bug
branch
from
87d798e
to
c918255
Compare
julianxhokaxhiu
previously approved these changes
Sep 24, 2022
|
Sorry, changed the commit message since it was kinda misleading |
julianxhokaxhiu
changed the title
|
There are actually issue with a scene. But not really sure if it can be fixed easily |
tangtang95
force-pushed
the
bugfix/widescreen-chocobo-bug
branch
from
c918255
to
91e5c52
Compare
|
I think it can be merged now. If there are other issues, it will be fixed next time |
…pt movements Fix julianxhokaxhiu#474 chocobo issue and fship_22 world/background movement.
tangtang95
force-pushed
the
bugfix/widescreen-chocobo-bug
branch
from
91e5c52
to
f5f118d
Compare
|
Sorry, had a misunderstanding with what Cosmos wrote, now, the solution should be better. |
julianxhokaxhiu
approved these changes
Sep 24, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #474 chocobo issue and fship_22 camera movement
ACKs