Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix solid queue tests #222

Merged
merged 8 commits into from
Oct 15, 2024
Merged

chore: Fix solid queue tests #222

merged 8 commits into from
Oct 15, 2024

Commits on Oct 12, 2024

  1. Configuration menu
    Copy the full SHA
    fbb7d02 View commit details
    Browse the repository at this point in the history
  2. Move past the ActiveModel error

    New error in Solid Queue 0.8.1 seems related to how we setup our test DB.
    adamlogic committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    064e97a View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Load entire SolidQueue schema file manually into our test DB

    SolidQueue v0.8+ merged all the migrations into a single schema file
    that is automatically loaded onto the DB on a Rails app. They suggest a
    separate DB, which AR will handle automatically by copying over this
    single file schema to the app, and to use on the same DB one would have
    to manually move the schema to a migration and execute it.
    
    For our case, all we care about is to have SolidQueue schema / tables
    loaded onto our test DB. We do that by manually loading the lib's schema
    file via Active Record. We still execute migrations afterwards, even
    though it's a no-op for current SolidQueue, if they need to make new
    schema changes in the future, they'll come in the form of migrations.
    carlosantoniodasilva committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    7347435 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    58a9994 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2fe65a7 View commit details
    Browse the repository at this point in the history
  4. Add Gemfile to test SolidQueue minimum version 0.3.x

    This way we can test both minimum and whatever "current/latest" is.
    (currently v1.0)
    carlosantoniodasilva committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    4ad8060 View commit details
    Browse the repository at this point in the history
  5. Add specific Gemfile for judoscale-rails against v7.1

    Update GH matrix to skip unsupported Ruby versions on Rails 7.2 as well,
    (main Gemfile for now) since it requires Ruby 3.1+.
    carlosantoniodasilva committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    7cb5114 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Move explicit require of ActiveModel to the test helper

    We already have a few other requires that were needed there to get tests
    running, we can keep this new one there too, as it should not be a
    problem in runtime within a normal Rails environment. (and if it happens
    to be, we'll learn about it soon enough.)
    carlosantoniodasilva committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    4569b0a View commit details
    Browse the repository at this point in the history