Skip starting Judoscale reporter on rails runner process
#217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to when running the `rails console`, we want to skip the reporter on `rails runner` to prevent it initializing another background thread and triggering an API call to our backend when executing one-off commands via the runner.
adamlogic
approved these changes
Oct 7, 2024
|
I think it's a solid queue issue with not requiring the proper ActiveModel module they rely on... it's not a problem in a Rails app I don't think, but for us that require only the lib via I will do a little more investigation, while I think it's something that should be fixed there, we could potentially require the missing file on our side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to when running the
rails console, we want to skip the reporter onrails runnerto prevent it initializing another background thread and triggering an API call to our backend when executing one-off commands via the runner.console: https://github.com/rails/rails/blob/a2f2dc8afd38b2d4ebd0170a75be2910fd7e4e45/railties/lib/rails/commands/console/console_command.rb
runner: https://github.com/rails/rails/blob/a2f2dc8afd38b2d4ebd0170a75be2910fd7e4e45/railties/lib/rails/commands/runner/runner_command.rb