feat: Support GoodJob v4 #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support to GoodJob v4. The main change is that queries now go through `GoodJob::Job` instead of `GoodJob::Execution`, based on the changelog: > Enqueues and executes jobs via the GoodJob::Job model instead of GoodJob::Execution They've also dropped support to Ruby 2.6/2.7, which we still support. I've tweaked the existing Gemfile for AR 6.1 to run against GoodJob v3, so we have test coverage there, and the main Gemfile and AR 7.0 versions will run against v4 going forward. Similarly, we have 2 sample apps for GoodJob, and I've kept one pointing to GoodJob v3 (the multi-db sample), while upgrading the other to v4, so we can test both for now. https://island94.org/2024/07/introducing-goodjob-v4
carlosantoniodasilva
pushed a commit
that referenced
this pull request
Jul 10, 2024
## [1.8.0](v1.7.1...v1.8.0) (2024-07-09) ### Features * Support GoodJob v4 ([#213](#213)) ([1d8f75c](1d8f75c)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to GoodJob v4. The main change is that queries now go
through
GoodJob::Jobinstead ofGoodJob::Execution, based on thechangelog:
They've also dropped support to Ruby 2.6/2.7, which we still support.
I've tweaked the existing Gemfile for AR 6.1 to run against GoodJob v3,
so we have test coverage there, and the main Gemfile and AR 7.0 versions
will run against v4 going forward.
Similarly, we have 2 sample apps for GoodJob, and I've kept one pointing
to GoodJob v3 (the multi-db sample), while upgrading the other to v4, so
we can test both for now.
https://island94.org/2024/07/introducing-goodjob-v4
https://github.com/bensheldon/good_job/tree/v4.0.2?tab=readme-ov-file#upgrading-v3-to-v4
Closes https://linear.app/judo/issue/PRD-579/add-support-for-goodjob-v4