Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't start the reporter in build processes #180

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Don't start the reporter in build processes #180

merged 3 commits into from
Aug 9, 2023

Commits on Aug 9, 2023

  1. Don't start the reporter in build processes 

    During build processes such as asset precompiling or database migrations, there's no need to report metrics. We've seen instances of these reports causing unexpected scaling.

There's no surefire way to know when we're in a build process, so we're checking for the presence of a Rake task. We need to allow for rake tasks that run jobs, though, and we do that through the `config.allow_rake_tasks` option. This is set automatically for DelayedJob and Resque.

We're also no longer including the middleware when running a Rails console. This wasn't causing problems, but it added noise to the console output.
    @adamlogic
    adamlogic committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    1f2e1f5 View commit details
    Browse the repository at this point in the history

  2. Fix tests

    @adamlogic
    adamlogic committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    b09efac View commit details
    Browse the repository at this point in the history

  3. Require "set" for older Ruby versions

    @adamlogic
    adamlogic committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    c2d3ae3 View commit details
    Browse the repository at this point in the history