Skip to content

Commit

Permalink
fix: Allow customizing the rake task regex to avoid starting the repo…
Browse files Browse the repository at this point in the history
…rter (#220)
  • Loading branch information
adamlogic authored Oct 16, 2024
1 parent 3072fa3 commit ed6c30a
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 2 deletions.
3 changes: 2 additions & 1 deletion judoscale-rails/lib/judoscale/rails/config.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@
module Judoscale
module Rails
module Config
attr_accessor :start_reporter_after_initialize
attr_accessor :start_reporter_after_initialize, :rake_task_ignore_regex

def reset
super
@start_reporter_after_initialize = true
@rake_task_ignore_regex = /assets:|db:/
end
end

Expand Down
2 changes: 1 addition & 1 deletion judoscale-rails/lib/judoscale/rails/railtie.rb
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def judoscale_config
config.after_initialize do
if in_rails_console_or_runner?
logger.debug "No reporting since we're in a Rails console or runner process"
elsif in_rake_task?(/assets:|db:/)
elsif in_rake_task?(judoscale_config.rake_task_ignore_regex)
logger.debug "No reporting since we're in a build process"
elsif judoscale_config.start_reporter_after_initialize
Reporter.start
Expand Down
4 changes: 4 additions & 0 deletions judoscale-rails/test/config_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,9 @@ module Judoscale
it "adds the start_reporter_after_initialize config option" do
_(::Judoscale::Config.instance.start_reporter_after_initialize).must_equal true
end

it "adds the rake_task_ignore_regex config option" do
_(::Judoscale::Config.instance.rake_task_ignore_regex).must_equal(/assets:|db:/)
end
end
end
1 change: 1 addition & 0 deletions sample-apps/rails-sample/config/initializers/judoscale.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
Judoscale.configure do |config|
# Open https://judoscale-adapter-mock.requestcatcher.com in a browser to monitor requests
config.api_base_url = ENV["JUDOSCALE_URL"] || "https://judoscale-adapter-mock.requestcatcher.com"
config.rake_task_ignore_regex = /assets:|db:|middleware/
# config.start_reporter_after_initialize = false
end

0 comments on commit ed6c30a

Please sign in to comment.