fix: Gracefully fail when JUDOSCALE_URL is a blank string

judoscale · Oct 12, 2023 · ca565d3 · ca565d3
1 parent 050e7b7
commit ca565d3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/judoscale-ruby/lib/judoscale/reporter.rb b/judoscale-ruby/lib/judoscale/reporter.rb
@@ -19,7 +19,7 @@ def self.start(config = Config.instance, adapters = Judoscale.adapters)
     def start!(config, adapters)
       @pid = Process.pid
 
-      if !config.api_base_url
+      if config.api_base_url.nil? || config.api_base_url.strip.empty?
         logger.debug "Set api_base_url to enable metrics reporting"
         return
       end

diff --git a/judoscale-ruby/test/reporter_test.rb b/judoscale-ruby/test/reporter_test.rb
@@ -122,6 +122,16 @@ def stub_reporter_loop
         _(log_string).must_include "Set api_base_url to enable metrics reporting"
       end
 
+      it "does not run the reporter thread when the API url is a blank string" do
+        Judoscale.configure { |config| config.api_base_url = " " }
+
+        Reporter.instance.stub(:run_loop, ->(*) { raise "SHOULD NOT BE CALLED" }) {
+          Reporter.instance.start!(Config.instance, Judoscale.adapters)
+        }
+
+        _(log_string).must_include "Set api_base_url to enable metrics reporting"
+      end
+
       it "does not run the reporter thread when there are no metrics collectors" do
         Reporter.instance.stub(:run_loop, ->(*) { raise "SHOULD NOT BE CALLED" }) {
           Reporter.instance.start!(Config.instance, Judoscale.adapters.select { |a| a.metrics_collector.nil? })