Single reporter across adapters #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reporter does not need access to the metrics store—that's the responsibility of the collectors, particularly the web metrics collector.
It doesn't actually do anything yet other than start the reporter. No metrics collected. No singleton reporter (BullMQ and Express each start their own reporter).
This required making the `collect` function async, along with the calling methods. We kept the `Reporter#start` method sync (not async) by resolving the `report` promise manually.
Base automatically changed from
adam/prd-287-add-bullbullmq-support-to-node-adapter
to
main
May 24, 2024 18:30
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change that changes the API our customers use to integrate the adapter. All integrations are now required to initialize Judoscale via
new Judoscale(), passing an optional configuration. This ensures consistency as we add new integrations. Web integrations (Express & Fastify) also expose a middleware or plugin for capturing request queue time.