Remove unused argument from Reporter#start

The reporter does not need access to the metrics store—that's the responsibility of the collectors, particularly the web metrics collector.
judoscale · May 20, 2024 · 9610b08 · 9610b08
1 parent c2819f5
commit 9610b08
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/express/src/index.js b/express/src/index.js
@@ -8,7 +8,7 @@ export default (config) => {
   const collectors = [new WebMetricsCollector(store)]
   const reporter = new Reporter()
 
-  reporter.start(finalConfig, store, collectors, Adapter)
+  reporter.start(finalConfig, collectors, Adapter)
 
   return ({ headers }, _res, next) => {
     const now = finalConfig.now || new Date()

diff --git a/fastify/src/plugin.js b/fastify/src/plugin.js
@@ -9,7 +9,7 @@ async function judoscaleFastify(fastify, options) {
   const collectors = [new WebMetricsCollector(metricsStore)]
   const reporter = new Reporter()
 
-  reporter.start(finalConfig, metricsStore, collectors, Adapter)
+  reporter.start(finalConfig, collectors, Adapter)
 
   fastify.addHook('onRequest', async (request, _reply) => {
     try {

diff --git a/node-core/src/lib/reporter.js b/node-core/src/lib/reporter.js
@@ -7,7 +7,7 @@ class Reporter {
     this.started = this.hasStarted() || false
   }
 
-  start(config, store, collectors, Adapter) {
+  start(config, collectors, Adapter) {
     if (!this.hasStarted()) {
       this.started = true