Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows bat file to build JSX #319

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

windows bat file to build JSX #319

wants to merge 1 commit into from

Conversation

shibukawa
Copy link
Contributor

No description provided.

@kazuho
Copy link
Member

kazuho commented Apr 11, 2014

Thank you for the PR.

Code in the PR states that https://code.google.com/p/msysgit/ is required. My understanding is that make is bundled with msysgit. Is there a reason not to use make?

@shibukawa
Copy link
Contributor Author

msysgit doesn't include development tools. make is not in the distribution (I checked 1.8.4 and 1.9.0).

@kazuho
Copy link
Member

kazuho commented Apr 12, 2014

Thank you for checking that.

I am not inclined to merge this PR as is due to the following reasons.

  • having copy-pasted code for various environments is not a good idea
  • proposed PR only covers a small portion of the build process; it does provide a way to run the equivalent of make test or make bootstrap-server etc., and thus IMO is a incomplete to be considered as a development environment for Windows

My understanding is that users may install jsx on Windows using npm and they can also install make to develop JSX. Please correct me if I am wrong.

@shibukawa
Copy link
Contributor Author

I made this script to test issue #316. If the fix would be published (it seems not to be published yet), the priority weill be low.

It is a first version. In future, I will find other Winows issues, I will create other target too.

@kazuho
Copy link
Member

kazuho commented Apr 14, 2014

Understood, though I would advise to implement the tests as part of the test suite (instead of copy-pasted build script) so that we could automatically detect regressions.

Regarding the next release, I would like to wait for #309 get finished, since I do not want to occasionally introduce incompatibilities in the toolchain (and we have already merged #313 that does this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants