[WIP] json for theme 2.0 #3143

libertymayc · 2024-03-19T19:31:08Z

Builds from color-palette-next branch to use salt theme 2.0

changeset-bot · 2024-03-19T19:31:12Z

🦋 Changeset detected

Latest commit: 2bb83c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@salt-ds/theme	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2024-03-19T19:31:17Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
saltdesignsystem	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 17, 2024 4:01pm

libertymayc · 2024-03-19T19:34:18Z

packages/theme/json/theme.json

-          "opacity": "{foundations.opacity.opacity-8}"
-        },
+      "color-white-8a": {
+        "$value": "#ffffff00",


unsure where opacity stands in theme 2.0, if we would link to an opacity foundation here, and have color and opacity as separate values like the JSON structure for theme 1 fade tokens @origami-z

libertymayc · 2024-03-19T21:30:38Z

packages/theme/json/parsers/validate.js

+  }
+}
+
+function validate() {


@origami-z this should check all paths are correct refs

libertymayc · 2024-03-20T17:35:37Z

/release-pr

github-actions · 2024-03-20T17:38:35Z

🫰✨ Thanks @libertymayc! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/core@0.0.0-snapshot-20240320173647

yarn add @salt-ds/lab@0.0.0-snapshot-20240320173647

yarn add @salt-ds/theme@0.0.0-snapshot-20240320173647

github-actions · 2024-03-20T17:41:00Z

Storybook Preview Link https://c21ee998.saltdesignsystem-storybook.pages.dev

libertymayc · 2024-03-20T19:47:23Z

/release-pr

github-actions · 2024-03-20T19:50:19Z

🫰✨ Thanks @libertymayc! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/core@0.0.0-snapshot-20240320194833

yarn add @salt-ds/lab@0.0.0-snapshot-20240320194833

yarn add @salt-ds/theme@0.0.0-snapshot-20240320194833

libertymayc · 2024-03-20T19:54:57Z

/release-pr

github-actions · 2024-03-20T19:57:53Z

🫰✨ Thanks @libertymayc! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/core@0.0.0-snapshot-20240320195607

yarn add @salt-ds/lab@0.0.0-snapshot-20240320195607

yarn add @salt-ds/theme@0.0.0-snapshot-20240320195607

libertymayc · 2024-04-22T14:47:08Z

/release-pr

github-actions · 2024-04-22T14:50:04Z

🫰✨ Thanks @libertymayc! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/core@0.0.0-snapshot-20240422144812

yarn add @salt-ds/theme@0.0.0-snapshot-20240422144812

github-actions · 2024-05-17T15:41:05Z

🫰✨ Thanks @libertymayc! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/core@0.0.0-snapshot-20240517153906

yarn add @salt-ds/lab@0.0.0-snapshot-20240517153906

yarn add @salt-ds/theme@0.0.0-snapshot-20240517153906

…irs. foundations only override if -next file is provided

libertymayc · 2024-05-17T15:52:05Z

/release-pr

github-actions · 2024-05-17T15:55:18Z

🫰✨ Thanks @libertymayc! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/core@0.0.0-snapshot-20240517155318

yarn add @salt-ds/lab@0.0.0-snapshot-20240517155318

yarn add @salt-ds/theme@0.0.0-snapshot-20240517155318

origami-z · 2024-10-21T13:59:23Z

Some quick thoughts for future myself while starting #4041, trying to think how we can best leverage tools out there, e.g. v4 of style-dictionary supports DTCG now.

packages/theme/json/theme.json, need to think about tooling compatibility on top level mode/density/etc blocks, how can we indicate they are replacements
- e.g., should it be $modes as key, { [modeName: string]: Array<string> } as value
To help use tools out there, trying to see how existing tools define variable "modes"
- If there are format out there, test them
- If not, think about whether Salt format / tool should be used to produce individual json (in specific mode/density/stylingOptions) to use other tools

libertymayc force-pushed the theme-json-theme-2.0 branch from 87fbbe9 to dd534f3 Compare March 19, 2024 19:32

libertymayc commented Mar 19, 2024

View reviewed changes

libertymayc requested a review from origami-z March 19, 2024 19:35

vercel bot had a problem deploying to Preview March 19, 2024 19:58 Failure

libertymayc commented Mar 19, 2024

View reviewed changes

vercel bot had a problem deploying to Preview March 19, 2024 21:43 Failure

vercel bot had a problem deploying to Preview March 20, 2024 14:44 Failure

libertymayc force-pushed the theme-json-theme-2.0 branch from cae97df to 6952b0f Compare March 20, 2024 17:35

github-actions bot deployed to saltdesignsystem-storybook (Preview) March 20, 2024 17:40 View deployment

vercel bot deployed to Preview March 20, 2024 17:54 View deployment

libertymayc changed the base branch from theme-json to main March 20, 2024 19:47

github-actions bot deployed to saltdesignsystem-storybook (Preview) March 20, 2024 20:00 View deployment

vercel bot deployed to Preview March 20, 2024 20:01 View deployment

github-actions bot deployed to saltdesignsystem-storybook (Preview) March 21, 2024 14:56 View deployment

vercel bot deployed to Preview March 21, 2024 15:12 View deployment

libertymayc force-pushed the theme-json-theme-2.0 branch from 229eddc to 8655e8c Compare April 22, 2024 14:46

github-actions bot deployed to saltdesignsystem-storybook (Preview) April 22, 2024 14:52 View deployment

vercel bot deployed to Preview April 22, 2024 14:53 View deployment

[Theme next] Adds unified color palette

2d37cb1

libertymayc added 13 commits May 17, 2024 10:57

change build

55d5fb8

add characteristics

50f07db

fix glitches

c6fbfeb

fix foundations

a1726b7

rm

6fa2a03

fix typography

5fe0e70

Pull theme from color-palette-next branch

db67871

file

36a57b5

pause

f3ab071

theme 2.0

c562047

updates based on unified-color-palette branch

95122e2

fix

14590b0

include fonts and corners from new theme

8fd8f1c

libertymayc force-pushed the theme-json-theme-2.0 branch from 200c7fd to 8fd8f1c Compare May 17, 2024 15:34

libertymayc added 2 commits May 17, 2024 11:35

undo gitignore

8f6bd3c

undo delete theme-next.css

d93d47c

libertymayc mentioned this pull request May 17, 2024

Theme Next: unified color palette #3255

Merged

2 tasks

vercel bot temporarily deployed to Preview May 17, 2024 15:45 Inactive

change to only include -next files from characteristics and palette d…

2bb83c3

…irs. foundations only override if -next file is provided

libertymayc force-pushed the theme-json-theme-2.0 branch from 3f902cd to 2bb83c3 Compare May 17, 2024 15:51

vercel bot deployed to Preview May 17, 2024 15:55 View deployment

origami-z force-pushed the unified-color-palette branch 3 times, most recently from f260109 to 09d4ce5 Compare May 22, 2024 15:51

Base automatically changed from unified-color-palette to main May 22, 2024 16:10

origami-z mentioned this pull request Aug 28, 2024

JSON representation for theme #4041

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] json for theme 2.0 #3143

[WIP] json for theme 2.0 #3143

libertymayc commented Mar 19, 2024

changeset-bot bot commented Mar 19, 2024 •

edited

Loading

vercel bot commented Mar 19, 2024 •

edited

Loading

libertymayc Mar 19, 2024

libertymayc Mar 19, 2024

libertymayc commented Mar 20, 2024

github-actions bot commented Mar 20, 2024

github-actions bot commented Mar 20, 2024 •

edited

Loading

libertymayc commented Mar 20, 2024

github-actions bot commented Mar 20, 2024

libertymayc commented Mar 20, 2024

github-actions bot commented Mar 20, 2024

libertymayc commented Apr 22, 2024

github-actions bot commented Apr 22, 2024

github-actions bot commented May 17, 2024

libertymayc commented May 17, 2024

github-actions bot commented May 17, 2024

origami-z commented Oct 21, 2024 •

edited

Loading

[WIP] json for theme 2.0 #3143

Are you sure you want to change the base?

[WIP] json for theme 2.0 #3143

Conversation

libertymayc commented Mar 19, 2024

changeset-bot bot commented Mar 19, 2024 • edited Loading

🦋 Changeset detected

vercel bot commented Mar 19, 2024 • edited Loading

libertymayc Mar 19, 2024

Choose a reason for hiding this comment

libertymayc Mar 19, 2024

Choose a reason for hiding this comment

libertymayc commented Mar 20, 2024

github-actions bot commented Mar 20, 2024

github-actions bot commented Mar 20, 2024 • edited Loading

libertymayc commented Mar 20, 2024

github-actions bot commented Mar 20, 2024

libertymayc commented Mar 20, 2024

github-actions bot commented Mar 20, 2024

libertymayc commented Apr 22, 2024

github-actions bot commented Apr 22, 2024

github-actions bot commented May 17, 2024

libertymayc commented May 17, 2024

github-actions bot commented May 17, 2024

origami-z commented Oct 21, 2024 • edited Loading

changeset-bot bot commented Mar 19, 2024 •

edited

Loading

vercel bot commented Mar 19, 2024 •

edited

Loading

github-actions bot commented Mar 20, 2024 •

edited

Loading

origami-z commented Oct 21, 2024 •

edited

Loading