Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quicklink #646

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Add quicklink #646

merged 1 commit into from
Nov 27, 2023

Conversation

stereobooster
Copy link
Contributor

@stereobooster stereobooster commented Sep 11, 2023

Add quicklink, as proposed here #644

Related Firefox issue: GoogleChromeLabs/quicklink#262 (comment)

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for hugo-congo ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1e32419
🔍 Latest deploy log https://app.netlify.com/sites/hugo-congo/deploys/65644cc780d86d00086ffa52
😎 Deploy Preview https://deploy-preview-646--hugo-congo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jpanther
Copy link
Owner

I do wonder how much of a performance benefit this adds to a static site, but I'm not opposed to adding it in. Is it worth limiting how many links can be prefetched?

@stereobooster
Copy link
Contributor Author

stereobooster commented Nov 26, 2023

I do wonder how much of a performance benefit this adds to a static site,

Depends how you judge it. Let's say that fastest server (CDN) can deliver HTTP response in 100-200ms (mainly network, I guess server itself would take 1ms max to generate response). It seems like not much, but page navigation (at least to my perception) becomes instant, like in SPA.

Is it worth limiting how many links can be prefetched?

Not sure. quicklink already uses some heuristics, like it preloads only visible links (in viewport)

@jpanther
Copy link
Owner

Yeah I think this change is not going to cause many issues for the majority of users and if anyone does have a problem it's easy to opt-out with the config flag so I'm happy to merge it in.

@jpanther jpanther merged commit dba7573 into jpanther:dev Nov 27, 2023
6 checks passed
@stereobooster stereobooster deleted the quicklink branch November 27, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants