Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(atomWithLocation): replaceState function to use window.history.state instead of null #33

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

Flirre
Copy link
Collaborator

@Flirre Flirre commented Mar 10, 2024

Work mentioned here: #24 (comment)

@Flirre Flirre requested a review from dai-shi March 10, 2024 16:09
Copy link

codesandbox-ci bot commented Mar 10, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Flirre Flirre merged commit 9aba6f6 into jotaijs:main Mar 11, 2024
2 checks passed
@Flirre Flirre deleted the atomWithLocation-replaceState-state branch March 11, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants