-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Panic Key #13
base: master
Are you sure you want to change the base?
Handle Panic Key #13
Conversation
Receive Panic Key (messagetype=11, note=123) and disable all playingnotes
For programs like drums, create a file "config.txt" in the program folder and add the following line: melodicProgram=false
Hello @hairpeace0, thanks for this PR! I'm a bit late of 5 years lol |
Useful note for later: http://midi.teragonaudio.com/tech/midispec/ntnoff.htm
|
@josephernest What exactly do you want to edit. Can't you propose the changes you want to see? |
@hairpeace0 I want to merge the first commit only (5a6d187) but not the 2nd and the 3rd. Indeed adding a second definition file for an instrument (config.txt in addition to already-existing definition.txt) is not wanted. Also we don't want to make a specific definition-file parsing here: c702dd3#diff-12abeff96b5d42b373fde683a1301f9bd00c7f4c06dd7dfc6f2198e2809e915bR333. How, in Github, to merge only the 1st commit of this PR, but not the 2nd + 3rd @dosas ? |
I see two possibilities: Either the contributor rebases his changes and deletes the 2nd and 3rd commit If the contributor does not react. You could cherry pick the first commit and create a PR. |
Receive Panic Key (messagetype=11, note=123) and disable all
playingnotes