-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating to modern Rust #84
Open
umgefahren
wants to merge
7
commits into
jordanbray:main
Choose a base branch
from
umgefahren:new-stuff
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmyTRUEk
reviewed
Nov 29, 2023
dmyTRUEk
reviewed
Nov 29, 2023
dmyTRUEk
reviewed
Nov 29, 2023
Overall, looks good to me, if only @jordanbray accepted it... |
This looks great and I would love for it to be merged. However, having a PR (#71) open for almost 2 years now with no feedback, I don't think it ever will. Would you guys be interested in forking this crate under a new name? There are a few open PRs that we could merge. I would be happy to help but I don't have much Rust experience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request brings the library into the standards and convention of Rust at the time of writing, at least from my point of view.
failure
tothiserror
extern crate foo;
syntaxconst
.I really like this innovative, unconventional use of build.rs, however it also greatly increases build time. It might be possible to replace the build.rs file entirely by clever use of const. It might be even easier, once more operations are available to const.
However the usage of static mut seems unnecessary, but I don't have the time to implement those changes.
On a additional note I think it's sufficient to rely on docs.rs.