Elements with position: absolute & top properties are positioned incorrectly on sticky deactivation #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elements with CSS property
position
set toabsolute
are incorrectly positioned after ng-sticky gets deactivated iftop
attribute is different than0
.This is due to the fact that
removeSticky()
method leavestop
property active on previously stickied element (onlyposition
property gets removed on deactivation -this.el.nativeElement.style.position = '';
).Example:
Element which holds ng-sticky directive has the following CSS:
After sticky deactivation,
top
property stays active and is set to0
which places the element in a wrong place.This pull request solves the problem by removing the whole
style
attribute upon sticky deactivation.