Fixed buildargs format in CICD

jomariya23156 · Mar 31, 2024 · 4b1a863 · 4b1a863
1 parent 2fcc504
commit 4b1a863
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/.github/workflows/build_push_docker_hub.yaml b/.github/workflows/build_push_docker_hub.yaml
@@ -26,13 +26,13 @@ jobs:
     strategy:
       matrix:
         image: [
-          { name: web-ui, context: ./services/web-ui, file: ./services/web-ui/Dockerfile, buildargs: {} },
-          { name: training-service, context: ./services/training-service, file: ./services/training-service/Dockerfile, buildargs: {} },
-          { name: data-producer, context: ./services/data-producer, file: ./services/data-producer/Dockerfile, buildargs: {} },
-          { name: mlflow, context: ./services/mlflow, file: ./services/mlflow/Dockerfile, buildargs: {} },
-          { name: airflow-spark, context: ./services/airflow, file: ./services/airflow/Dockerfile, buildargs: { AIRFLOW_HOME: /opt/airflow } },
+          { name: web-ui, context: ./services/web-ui, file: ./services/web-ui/Dockerfile, buildargs: [] },
+          { name: training-service, context: ./services/training-service, file: ./services/training-service/Dockerfile, buildargs: [] },
+          { name: data-producer, context: ./services/data-producer, file: ./services/data-producer/Dockerfile, buildargs: [] },
+          { name: mlflow, context: ./services/mlflow, file: ./services/mlflow/Dockerfile, buildargs: [] },
+          { name: airflow-spark, context: ./services/airflow, file: ./services/airflow/Dockerfile, buildargs: [ 'AIRFLOW_HOME=/opt/airflow' ] },
           # for amd64 (x86_64) please leave ARCH_TRAILING_IMG_NAME empty
-          { name: ray, context: ./services/ray, file: ./services/ray/Dockerfile, buildargs: { MLFLOW_ARTIFACT_ROOT: /storage/mlruns, ARCH_TRAILING_IMG_NAME: "-aarch64" } }
+          { name: ray, context: ./services/ray, file: ./services/ray/Dockerfile, buildargs: [ 'MLFLOW_ARTIFACT_ROOT=/storage/mlruns', 'ARCH_TRAILING_IMG_NAME="-aarch64"' ] }
         ]
     steps:
       - name: Download repository artifact

diff --git a/README.md b/README.md
@@ -35,6 +35,7 @@ From doc: https://airflow.apache.org/docs/apache-airflow/stable/howto/docker-com
       2. `helm upgrade --install -n mlops kuberay-operator kuberay/kuberay-operator --version 1.1.0-rc.0`
    2. Deploy RayCluster Custom Resource (CR)
       1. `helm upgrade --install -n mlops raycluster kuberay/ray-cluster --version 1.1.0-rc.0 --set 'image.tag=2.9.3-py39-cpu-aarch64'`
+      2. Verify by `kubectl get rayclusters`
 
 **Note:** If you want to change namespace `kafka` and/or release name `kafka-release` of Kafka, please also change them in `values.yaml` and `KAFKA_BOOTSTRAP_SERVER` env var in `values-airflow.yaml`. They are also used in templating.