Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dot ast #2002

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Improve dot ast #2002

wants to merge 13 commits into from

Conversation

Liyw979
Copy link
Contributor

@Liyw979 Liyw979 commented Nov 20, 2022 •
edited
Loading

previous
graph (1)
now
graph (2)

@max-leuthaeuser max-leuthaeuser requested review from fabsx00 and removed request for fabsx00 February 6, 2023 07:08
@Liyw979
Copy link
Contributor Author

Liyw979 commented Feb 6, 2023

@fabsx00 Please review this one.

@evilpan
Copy link
Contributor

evilpan commented Mar 11, 2023

This seems better. Currently the plot is a little bit too wide to view, for example:
1873470016818528844

@Liyw979
Copy link
Contributor Author

Liyw979 commented Mar 11, 2023

@evilpan This is the primary target of this PR.

@max-leuthaeuser
Copy link
Contributor

max-leuthaeuser commented Mar 16, 2023 •
edited
Loading

Could you merge this with the current master to get the (new) tests running?

@itsacoderepo
Copy link
Contributor

@Liyw979 Thanks for the PR! Can you add line wrap instead of the .map(StringUtils.abbreviate(_, 50))?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evilpan evilpan evilpan approved these changes

@fabsx00 fabsx00 Awaiting requested review from fabsx00

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Liyw979 @evilpan @max-leuthaeuser @itsacoderepo