Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dsf bug #36

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix dsf bug #36

wants to merge 5 commits into from

Conversation

diablo2049
Copy link

No description provided.

diablo2049 and others added 5 commits August 21, 2022 10:45
fix the unexpected peaks in the end of the destination files, when source is dsf format
@jniemann66
Copy link
Owner

Hi Diablo2049.
I'm back, after a long hiatus !
just looking at your pull request now. Thanks for that !
Is there any chance you could privately send me the dsf file that was causing the grief (if it's not too huge) ? I want to replicate this problem myself.
I can see that you have added a check of the blocksize in the main loop.
I think the dsf reader should guarantee that it always returns exactly the number of frames it says it will ( in frames() function )
Looks to me like the reported chunk lengths in your dsf file might not match the actual lengths.
(That's why I'd love to study the file ...)

Sorry it's taken me 10 months to look at this :-)

Cheers
Judd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants