Workspace prep demo #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorbunkov
reviewed
May 12, 2023
There was a problem hiding this comment.
Speaking about further process definition improvements:
- Since we have some process logging, we may also demonstrate how to use execution or task listener. We may create a listener that will write a log message like "Task XXX has been started". This listener will be added to each user task.
- We don't demonstrate working with task outcomes in this sample. We could add outcomes to the Check request task, e.g. our favorite Approve - Reject or Complete and Restart (return the process to the beginning).
There was a problem hiding this comment.
Please create issues for future improvements
| @UiController("WorkspaceRequest.edit") | ||
| @UiDescriptor("workspace-request-edit.xml") | ||
| @EditedEntityContainer("workspaceRequestDc") | ||
| @ProcessForm(allowedProcessKeys = {"workspace-preparation"}) |
There was a problem hiding this comment.
Have you considered having a separate screen for process form? One screen will be a regular editor that has nothing to do with BPM and the second screen will be used as a process form only.
There was a problem hiding this comment.
Perhaps it's a good idea. Create an issue for this.
|
Finished minor fixes. Let's make other improvements later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.