Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for https connections #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tolomaus
Copy link

@tolomaus tolomaus commented Apr 2, 2015

Added support for https connections with either skipping the cert check or passing the cert file in an env variable.

This is especially useful as from neo4j 2.2 as the default is to run over https.

Unfortunately the Go https implementation does not accept the neo4j cert file that is automatically generated during the neo4j installation so you still have to create a key and cert file manually.

…ck or passing the cert file in an env variable
@jmcvetta
Copy link
Owner

jmcvetta commented Apr 3, 2015

Thanks for contributing! Please add a unit test to cover the new functionality, then I will be happy to merge the PR.

@tolomaus
Copy link
Author

tolomaus commented Apr 4, 2015

Sure, how would you suggest to do this?

When I set the version number to 2.2+ I expect the start-neo4j.sh script to run neo4j by default over https. Do you want to run all the existing test over https from now on? Better may be to test both http and https but this would imply installing two instances side by side or switching from one to the other at some point.

Ideally there should be a test that creates a self signed key and certificate to test out the https connection where the client passes a certificate (so not skipping the cert check).

@EmergentBehavior
Copy link

Any movement on this?

@ghost
Copy link

ghost commented Aug 24, 2016

I've created a PR to allow passing in a http.Client. That would also allow you to achieve what you want here by creating your own http.Client outside of neoism.

#97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants