Implement IStorageProvider OpenFile/OpenFolder/SaveFile dialogs #311
Annotations
1 error, 12 warnings, and 10 notices
|
Inspect code
Issues found.
|
|
The following actions uses node12 which is deprecated and will be forced to run on node16: xt0rted/pull-request-comment-branch@v1, actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
The following actions use a deprecated Node.js version and will be forced to run on node20: xt0rted/pull-request-comment-branch@v1, actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Inspect code:
src/Consolonia.Core/Controls/FileOpenPickerViewModel.cs#L34
"[AssignNullToNotNullAttribute] Possible 'null' assignment to non-nullable entity" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Controls/FileOpenPickerViewModel.cs(34,18)
|
|
Inspect code:
src/Consolonia.Core/Controls/PickerViewModelBase.cs#L17
"[AssignNullToNotNullAttribute] Possible 'null' assignment to non-nullable entity" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Controls/PickerViewModelBase.cs(17,33)
|
|
Inspect code:
src/Consolonia.Core/Controls/PickerViewModelBase.cs#L18
"[AssignNullToNotNullAttribute] Possible 'null' assignment to non-nullable entity" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Controls/PickerViewModelBase.cs(18,29)
|
|
Inspect code:
src/Tests/Consolonia.Core.Tests/StorageTests.cs#L65
"[AssignNullToNotNullAttribute] Possible 'null' assignment to non-nullable entity" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/StorageTests.cs(65,40)
|
|
Inspect code:
src/Tests/Consolonia.Core.Tests/StorageTests.cs#L117
"[AssignNullToNotNullAttribute] Possible 'null' assignment to non-nullable entity" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/StorageTests.cs(117,41)
|
|
Inspect code:
src/Tests/Consolonia.Core.Tests/StorageTests.cs#L37
"[CA1849] 'StreamWriter.Write(string?)' synchronously blocks. Await 'StreamWriter.WriteAsync(string?)' instead." on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/StorageTests.cs(37,21)
|
|
Inspect code:
src/Consolonia.Core/Controls/FileSavePickerViewModel.cs#L26
"[ConditionIsAlwaysTrueOrFalse] Expression is always true" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Controls/FileSavePickerViewModel.cs(26,17)
|
|
Inspect code:
src/Consolonia.Core/Controls/PickerViewModelBase.cs#L61
"[ConditionIsAlwaysTrueOrFalse] Expression is always true" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Controls/PickerViewModelBase.cs(61,17)
|
|
Inspect code:
src/Consolonia.Core/Controls/FileOpenPicker.axaml#L41
"[InconsistentNaming] Name 'OKButton' does not match rule 'XAML field'. Suggested name is 'OkButton'." on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Controls/FileOpenPicker.axaml(41,29)
|
|
Inspect code:
src/Consolonia.Core/Controls/FolderPicker.axaml#L34
"[InconsistentNaming] Name 'OKButton' does not match rule 'XAML field'. Suggested name is 'OkButton'." on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Controls/FolderPicker.axaml(34,29)
|
|
Inspect code:
src/Consolonia.Core/Controls/FileOpenPickerViewModel.cs#L27
"[ArrangeObjectCreationWhenTypeEvident] Redundant type specification" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Controls/FileOpenPickerViewModel.cs(27,73)
|
|
Inspect code:
src/Consolonia.Core/Controls/FolderPickerViewModel.cs#L17
"[ArrangeObjectCreationWhenTypeEvident] Redundant type specification" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Controls/FolderPickerViewModel.cs(17,77)
|
|
Inspect code:
src/Consolonia.Core/Controls/PickerViewModelBase.cs#L34
"[ArrangeObjectCreationWhenTypeEvident] Redundant type specification" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Controls/PickerViewModelBase.cs(34,65)
|
|
Inspect code:
src/Consolonia.Core/Infrastructure/SystemStorageFile.cs#L32
"[ArrangeObjectCreationWhenTypeEvident] Redundant type specification" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Infrastructure/SystemStorageFile.cs(32,32)
|
|
Inspect code:
src/Consolonia.Core/Infrastructure/SystemStorageFolder.cs#L35
"[ArrangeObjectCreationWhenTypeEvident] Redundant type specification" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Infrastructure/SystemStorageFolder.cs(35,32)
|
|
Inspect code:
src/Consolonia.Core/Controls/FileOpenPicker.axaml.cs#L58
"[ArrangeRedundantParentheses] Redundant parentheses" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Controls/FileOpenPicker.axaml.cs(58,21)
|
|
Inspect code:
src/Consolonia.Core/Controls/FileOpenPicker.axaml.cs#L59
"[ArrangeRedundantParentheses] Redundant parentheses" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Controls/FileOpenPicker.axaml.cs(59,21)
|
|
Inspect code:
src/Consolonia.Core/Controls/FolderPicker.axaml.cs#L59
"[ArrangeRedundantParentheses] Redundant parentheses" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Controls/FolderPicker.axaml.cs(59,21)
|
|
Inspect code:
src/Consolonia.Core/Controls/FolderPicker.axaml.cs#L60
"[ArrangeRedundantParentheses] Redundant parentheses" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Controls/FolderPicker.axaml.cs(60,21)
|
|
Inspect code:
src/Consolonia.Core/Infrastructure/SystemStorageFolder.cs#L33
"[ArrangeRedundantParentheses] Redundant parentheses" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Infrastructure/SystemStorageFolder.cs(33,31)
|
Loading