Add support for full RGB colors and TextDecorations #175
tomlmAnnotations
1 error, 12 warnings, and 10 notices
|
build
Issues found.
|
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: xt0rted/pull-request-comment-branch@v1, actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
build
The following actions use a deprecated Node.js version and will be forced to run on node20: xt0rted/pull-request-comment-branch@v1, actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
build:
src/Consolonia.Core/Drawing/DrawingContextImpl.cs#L145
"[AccessToModifiedClosure] Captured variable is modified in the outer scope" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/DrawingContextImpl.cs(145,93)
|
|
build:
src/Consolonia.Core/Drawing/DrawingContextImpl.cs#L145
"[AccessToModifiedClosure] Captured variable is modified in the outer scope" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/DrawingContextImpl.cs(145,96)
|
|
build:
src/Consolonia.Core/Drawing/RenderTarget.cs#L123
"[BadChildStatementIndent] Line indent is not restored to the previous level around child statement" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/RenderTarget.cs(123,1)
|
|
build:
src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelOperations.cs#L42
"[CompareOfFloatsByEqualityOperator] Equality comparison of floating point numbers. Possible loss of precision while rounding values" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelOperations.cs(42,65)
|
|
build:
src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelOperations.cs#L70
"[CompareOfFloatsByEqualityOperator] Equality comparison of floating point numbers. Possible loss of precision while rounding values" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelOperations.cs(70,65)
|
|
build:
src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelForeground.cs#L12
"[ConstantNullCoalescingCondition] '??' left operand is never null" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelForeground.cs(12,32)
|
|
build:
src/Consolonia.Core/Text/TextShaper.cs#L17
"[ConstantNullCoalescingCondition] '??' left operand is never null" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Text/TextShaper.cs(17,37)
|
|
build:
src/Consolonia.Core/Drawing/ConsoleBrush.cs#L189
"[PossibleNullReferenceException] Possible 'System.NullReferenceException'" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/ConsoleBrush.cs(189,24)
|
|
build:
src/Consolonia.Core/Drawing/PixelBufferImplementation/Pixel.cs#L31
"[RedundantArgumentDefaultValue] The parameter 'style' has the same default value" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/Pixel.cs(31,70)
|
|
build:
src/Consolonia.Core/Drawing/PixelBufferImplementation/Pixel.cs#L31
"[RedundantArgumentDefaultValue] The parameter 'weight' has the same default value" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/Pixel.cs(31,88)
|
|
build:
src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelOperations.cs#L42
"[ArrangeRedundantParentheses] Redundant parentheses" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelOperations.cs(42,64)
|
|
build:
src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelOperations.cs#L70
"[ArrangeRedundantParentheses] Redundant parentheses" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelOperations.cs(70,64)
|
|
build:
src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelOperations.cs#L88
"[ArrangeRedundantParentheses] Redundant parentheses" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelOperations.cs(88,20)
|
|
build:
src/Consolonia.PlatformSupport/WindowsConsole.cs#L166
"[ArrangeRedundantParentheses] Redundant parentheses" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.PlatformSupport/WindowsConsole.cs(166,39)
|
|
build:
src/Consolonia.Core/Drawing/PixelBufferImplementation/Pixel.cs#L75
"[ArrangeThisQualifier] Qualifier 'this.' is redundant" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/Pixel.cs(75,25)
|
|
build:
src/Consolonia.Core/Drawing/PixelBufferImplementation/Pixel.cs#L79
"[ArrangeThisQualifier] Qualifier 'this.' is redundant" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/Pixel.cs(79,61)
|
|
build:
src/Consolonia.Core/Drawing/PixelBufferImplementation/Pixel.cs#L79
"[ArrangeThisQualifier] Qualifier 'this.' is redundant" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/Pixel.cs(79,85)
|
|
build:
src/Consolonia.Core/Drawing/PixelBufferImplementation/Pixel.cs#L79
"[ArrangeThisQualifier] Qualifier 'this.' is redundant" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/Pixel.cs(79,109)
|
|
build:
src/Consolonia.Core/Drawing/PixelBufferImplementation/Pixel.cs#L79
"[ArrangeThisQualifier] Qualifier 'this.' is redundant" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/Pixel.cs(79,160)
|
|
build:
src/Consolonia.Core/Text/FontManagerImpl.cs#L38
"[ArrangeTrailingCommaInMultilineLists] Remove trailing comma to conform to code style" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Text/FontManagerImpl.cs(38,30)
|