Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24 #25

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Fixes #24 #25

merged 3 commits into from
Jun 7, 2024

Conversation

bhoov
Copy link
Contributor

@bhoov bhoov commented Jun 6, 2024

Boolean error is easily fixed by adding tostring

@jimjam-slam
Copy link
Owner

Thanks @bhoov! Looks like I forgot to cast a Boolean in a debugging statement. Not sure why it never caused a problem for me in testing, though 🤔 Will try to merge today!

@jimjam-slam
Copy link
Owner

Ah, I see; I didn't sufficiently test the single doc render code path (the Svelte compilation is handled y a separate script if you render as part of a project, and the code that locates the Svelte config is only in that script). I'll get both of these fixed up for you!

@jimjam-slam
Copy link
Owner

I've pushed an additional commit to this PR that additionally fixes #23 - the underlying problem is that when rendering a single doc, I wasn't making the path to the Rollup config available (#24 was a secondary error happening when trying to report the first). I'm just running checks, and then I'll merge both :)

@jimjam-slam jimjam-slam merged commit 88a75c3 into jimjam-slam:main Jun 7, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants