Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0 #20

Merged
merged 42 commits into from
May 11, 2024
Merged

v1.0 #20

merged 42 commits into from
May 11, 2024

Conversation

jimjam-slam
Copy link
Owner

@jimjam-slam jimjam-slam commented Mar 17, 2024

Major refactor that drastically simplifies Sverto's operation. No more big document transforms to try and modify OJS code; we just inject the Svelte module into OJS using vanilla JS!

Things I'd like to polish up before release:

  • Less shell output on render (particularly with respect to the custom command line args we send to rollup)
  • Windows support (see Template error: ERROR: Include directive failed  #15)
  • More examples
  • Replace my path normaliser with pandoc's normalize() to avoid duplicate Svelte compilations
  • Absolute paths still need to be made relative to the project root

@jimjam-slam jimjam-slam self-assigned this Mar 17, 2024
@jimjam-slam
Copy link
Owner Author

jimjam-slam commented Mar 20, 2024

Windows support is the last big thing to figure out here before we focus on documentation and examples! See #15. I need to dig out my gaming PC and run Sverto locally; the GitHub Actions CI is not adequately exposing output from sverto-prerender.lua and rollup.config.js.

1.5.25 contains a bug fix preventing Lua scripts from executing on Windows
@jimjam-slam
Copy link
Owner Author

As of commit 54375e8, things are running on Windows! Turns out this was a Quarto bug affecting Lua scripts that has been resolved in pre-release v1.5.25.

@jimjam-slam jimjam-slam marked this pull request as ready for review May 11, 2024 09:45
@jimjam-slam jimjam-slam merged commit ccce346 into main May 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant