Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New resource for individual project members #99

Closed

Conversation

Danielku15
Copy link
Contributor

@Danielku15 Danielku15 commented Feb 27, 2024

This PR relates to #98

It adds a new dedicated resource which allows managing project members without touching the project itself. In our Company-wide Artifactory instance we are given 1 project by the admins and the project is mostly readonly. We can add members and manage repositories but nothing else.

With this resource we can:

  1. Add new project members to the existing project without touching it.
  2. We can still manage some memberships manually without interference with the terraform state.
  3. We can auto-generate a list of users who should have theoretically access IF the accounts exist and still apply without errors (only warnings). This serves the use case where we have a central list of developers and we don't know if they already have an account in artifactory (e.g. missing SSO login). We will see who is missing a user without failing to apply users who have one.

Unfortunately I cannot run the tests on our company artifactory instance due to permissions. But I tried to prepare already some tests. Any help in finalizing the tests is appreciated (providing an artifactory for testing or taking over to write the tests).

I made some manual tests by using the locally compiled provider and creating members in our project.

Copy link

github-actions bot commented Feb 27, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Danielku15 Danielku15 force-pushed the feature/resource-project-member branch from e7bd4c1 to 5676040 Compare February 27, 2024 14:23
@Danielku15
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@Danielku15
Copy link
Contributor Author

Superceeded by #100

@Danielku15 Danielku15 closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant