Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the correct env pointer is used after matching #92

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

alexhung
Copy link
Member

Set the new environment name after updating so that the read func fetches the correct environment

Close #90

Set the new environment name after updating so that the read func fetches the correct environment
@alexhung alexhung added the bug Something isn't working label Oct 30, 2023
@alexhung alexhung marked this pull request as ready for review October 30, 2023 21:43
@@ -69,6 +69,7 @@ func projectEnvironmentResource() *schema.Resource {
for _, env := range envs {
if env.Name == fmt.Sprintf("%s-%s", projectKey, data.Get("name")) {
matchedEnv = &env
break
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh! 🤦🏼‍♂️

@alexhung alexhung merged commit 7169bf8 into master Oct 30, 2023
1 check passed
@alexhung alexhung deleted the GH-90-fix-import-project-env-issue branch October 30, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing project environment shows diff
3 participants