Enable auth with OpenID Connect #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eranturgeman
had a problem deploying
to
frogbot
GitHub Actions
Failure
eranturgeman
had a problem deploying
to
frogbot
GitHub Actions
Failure
eranturgeman
had a problem deploying
to
frogbot
GitHub Actions
Failure
eranturgeman
had a problem deploying
to
frogbot
GitHub Actions
Failure
eranturgeman
had a problem deploying
to
frogbot
GitHub Actions
Failure
eranturgeman
had a problem deploying
to
frogbot
GitHub Actions
Failure
eranturgeman
had a problem deploying
to
frogbot
GitHub Actions
Failure
eranturgeman
had a problem deploying
to
frogbot
GitHub Actions
Failure
eranturgeman
had a problem deploying
to
frogbot
GitHub Actions
Failure
eranturgeman
had a problem deploying
to
frogbot
GitHub Actions
Failure
eranturgeman
had a problem deploying
to
frogbot
GitHub Actions
Failure
eranturgeman
had a problem deploying
to
frogbot
GitHub Actions
Failure
eranturgeman
had a problem deploying
to
frogbot
GitHub Actions
Failure
eranturgeman
had a problem deploying
to
frogbot
GitHub Actions
Failure
eranturgeman
had a problem deploying
to
frogbot
GitHub Actions
Failure
eranturgeman
had a problem deploying
to
frogbot
GitHub Actions
Failure
eranturgeman
had a problem deploying
to
frogbot
GitHub Actions
Failure
eranturgeman
had a problem deploying
to
frogbot
GitHub Actions
Failure
eranturgeman
had a problem deploying
to
frogbot
GitHub Actions
Failure
eranturgeman
had a problem deploying
to
frogbot
GitHub Actions
Failure
eranturgeman
had a problem deploying
to
frogbot
GitHub Actions
Failure
eranturgeman
had a problem deploying
to
frogbot
GitHub Actions
Failure
eranturgeman
had a problem deploying
to
frogbot
GitHub Actions
Failure
eranturgeman
had a problem deploying
to
frogbot
GitHub Actions
Failure
yahavi
requested changes
Jan 11, 2024
There was a problem hiding this comment.
Well done @eranturgeman!🏅
Please consider my inline comments. I'd ask to review again after all comments are resolved.
yahavi
requested changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run formatfor formatting the code before submitting the pull request.This Feature enable using OpenID-Connect protocol.
This ability allows the user to get an access token for Artifactory without saving it as a secret in the repo we call setup-jfrog-cli action.
For the full explenation about the new ability, please refer to the setup-jfrog-cli README.md