-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ansible/artifactory] Add mTLS support #392
base: master
Are you sure you want to change the base?
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
@shurikg Thanks for the PR ! We would like you to do some changes to this PR so that it’s generic . Here you have implemented for mtls however we looking at any accessConfig as a variable so that it can be customized !refer to systemYaml as a variable under vars.yaml as an example |
The JFrog manages the access.config.latest.yml file differently from all other configuration files. This file is generated automatically after the start of service. To update it we need to use a patch file which will be deleted after the service restart. To save the ansible idempotence concept, and mark the tasks as changed only when it's changed (it's crucial for our automation) I didn't find a way to implement mtls in the same way as you do for system.yaml file. This is why I did it this way (focusing on the missing MTLs part for us). If you have another idea on how we can manage the access file, but continue with the ansible idempotence concept, I will be glad to know. |
We understand the idempotence concept , if you are looking
please refer to here as example
we are happy to assist if you have any further questions Thanks |
PR Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[ansible/artifactory]
)What this PR does / why we need it:
Support configuration of mTLS for artifacts version 7.77 and above.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: