Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LogLevel Setting #300

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Add LogLevel Setting #300

wants to merge 5 commits into from

Conversation

ricaun
Copy link
Contributor

@ricaun ricaun commented Oct 8, 2024

Summary of the Pull Request

Add setting to control the log level of the RevitLookup.

What is this about:

The current version of RevitLookup use the fix level Debug, this PR allow to change the level to prevent unwanted log in the Console.

The default setting for the Minimal Log Level is Information, and could be changed in the Setting -> Other.

image

Quality Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

github-actions bot commented Oct 8, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@Nice3point
Copy link
Collaborator

Nice3point commented Oct 9, 2024

Great. But the problem is the idea itself, the user shouldn't be able to configure logging from the UI, they shouldn't know anything about it at all. 99% of users have no idea that logs are written to the console, nevertheless this information is important in case of issues. I'm not in favor of adding a logging level setting to the UI. The maximum is adding an option to the configuration file or restrict the Debug level by compilation directives

@ricaun
Copy link
Contributor Author

ricaun commented Oct 9, 2024

Great. But the problem is the idea itself, the user shouldn't be able to configure logging from the UI, they shouldn't know anything about it at all. 99% of users have no idea that logs are written to the console, nevertheless this information is important in case of issues. I'm not in favor of adding a logging level setting to the UI. The maximum is adding an option to the configuration file or restrict the Debug level by compilation directives

The majority of the user are developers and is really easy to teach/explain that information about the RevitLookup goes to the Console if the plugin have a UI for that.

If the user can choose what information is important depending of the necessity would be ideal, a UI in the setting is the most convenient place.

Like you said in case of issues the user can change the level to Verbose and flood the Console with info about the RevitLookup.

So you could inject a verbose log in the engine and show every single method/propriety that is been snoop, that info is only relevant in some use case.

And you could add more logs around in the plugin without worrying if log level are closable by the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants