-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LogLevel Setting #300
base: dev
Are you sure you want to change the base?
Add LogLevel Setting #300
Conversation
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Great. But the problem is the idea itself, the user shouldn't be able to configure logging from the UI, they shouldn't know anything about it at all. 99% of users have no idea that logs are written to the console, nevertheless this information is important in case of issues. I'm not in favor of adding a logging level setting to the UI. The maximum is adding an option to the configuration file or restrict the Debug level by compilation directives |
The majority of the user are developers and is really easy to teach/explain that information about the RevitLookup goes to the Console if the plugin have a UI for that. If the user can choose what information is important depending of the necessity would be ideal, a UI in the setting is the most convenient place. Like you said in case of issues the user can change the level to Verbose and flood the Console with info about the RevitLookup. So you could inject a verbose log in the engine and show every single method/propriety that is been snoop, that info is only relevant in some use case. And you could add more logs around in the plugin without worrying if log level are closable by the user. |
Summary of the Pull Request
Add setting to control the log level of the RevitLookup.
What is this about:
The current version of RevitLookup use the fix level Debug, this PR allow to change the level to prevent unwanted log in the Console.
The default setting for the Minimal Log Level is
Information
, and could be changed in theSetting -> Other
.Quality Checklist