Use nested module format for Java package names #2236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRuby provides two formats for referring to java package [1]. Sequel has historically used a mix of both formats. This consolidates on the "nested module" format (Java::JavaSql::Date) vs the java style format (java.sql.Date). Apart from internal consistency, this format also presents as more idiomatic Ruby, since there are no invalid module names, such as Java::oracle.jdbc.driver.OracleDriver (`oracle` is not a valid module name). [1] https://github.com/jruby/jruby/wiki/CallingJavaFromJRuby#referencing-java-classes-using-full-qualified-class-name Change-Id: I76a6786e011b4b54bfc96bb3c9bb288875d51bd6
|
My use case is only affected by the OracleTypes declarations, but I figured it would be worth covering the rest for consistency sake. I can reduce the scope of this if you like. |
|
Thanks for submitting a patch for this and fixing all cases. I probably will not have time to test this until this coming weekend, but as long as it passes all jdbc driver tests, I will merge it. |
|
All tests passed, so I'll merge this shortly. |
|
Cherry-picked at bba3e40 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JRuby provides two formats for referring to java package [1]. Sequel has historically used a mix of both formats. This consolidates on the "nested module" format (Java::JavaSql::Date) vs the java style format (java.sql.Date). Apart from internal consistency, this format also presents as more idiomatic Ruby, since there are no invalid module names, such as Java::oracle.jdbc.driver.OracleDriver (
oracleis not a valid module name).[1] https://github.com/jruby/jruby/wiki/CallingJavaFromJRuby#referencing-java-classes-using-full-qualified-class-name