Merge pull request #243 from sunnyqeen/Fix-JENKINS-33708

[JENKINS-33708] Do not call `nohup` for `sh` steps running on Windows
jenkinsci · Nov 22, 2024 · 299a560 · 299a560
2 parents 09f6e98 + 8b0af52
commit 299a560
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/main/java/org/jenkinsci/plugins/durabletask/BourneShellScript.java b/src/main/java/org/jenkinsci/plugins/durabletask/BourneShellScript.java
@@ -263,7 +263,7 @@ private List<String> scriptLauncherCmd(ShellController c, FilePath ws, @CheckFor
 
         cmdString = cmdString.replace("$", "$$"); // escape against EnvVars jobEnv in LocalLauncher.launch
         List<String> cmd = new ArrayList<>();
-        if (os != OsType.DARWIN) { // JENKINS-25848
+        if (os != OsType.DARWIN && os != OsType.WINDOWS) { // JENKINS-25848  JENKINS-33708
             cmd.add("nohup");
         }
         if (LAUNCH_DIAGNOSTICS) {