[JENKINS-73644] Use AWS SDK for Java 2.x #93
Draft
+80
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
commented
Nov 26, 2024
...main/java/io/jenkins/plugins/aws/global_configuration/CredentialsAwsGlobalConfiguration.java
Outdated
Show resolved
Hide resolved
| for (Regions s : Regions.values()) { | ||
| regions.add(s.getDescription(), s.getName()); | ||
| for (Region s : Region.regions()) { | ||
| regions.add(s.id(), s.id()); |
There was a problem hiding this comment.
Technically a change in behavior, as observed in the UI which now lacks region descriptions. Perhaps we could get these from the EC2 DescribeRegions API, although that requires read access. Or maybe this does not matter and we could dispense with displaying the region descriptions in the UI?
basil
changed the title
jglick
reviewed
Nov 27, 2024
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>aws-credentials</artifactId> | ||
| <!-- TODO https://github.com/jenkinsci/aws-credentials-plugin/pull/254 --> |
There was a problem hiding this comment.
basil
force-pushed
the
aws-java-sdk2
branch
4 times, most recently
from
ef8e7f4
to
12cf5eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in context with
artifact-manager-s3plugin. Ran a Pipeline job and confirmed the artifact was uploaded to S3. Clicked on the "Validate S3 bucket configuration" button and verified that the validation succeeded against my S3 bucket.