Add global setting to disable credential checking against AWS #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cperrin88
force-pushed
the
feature/optional-credential-check
branch
from
9aaf31f
to
8ae3640
Compare
|
Is there something missing? Do you need something to merge this? |
on-behalf-of: @e-solutions-GmbH <info@esolutions.de>
cperrin88
force-pushed
the
feature/optional-credential-check
branch
from
8ae3640
to
cb08bc1
Compare
|
Fixes #241 |
amuniz
reviewed
Jun 28, 2024
Comment on lines
+23
to
+25
| validateAgainstAWS = json.getBoolean("validateAgainstAWS"); | ||
| save(); | ||
| return super.configure(req, json); |
There was a problem hiding this comment.
Do you need to override this method? I think the default implementation in the parent class would already do what's expected.
There was a problem hiding this comment.
From what I see it doesn't. Neither the save nor the setting of the local variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds an option to disable the checking against AWS. The plugin is used in the caching plugin to store S3 credentials, even for local buckets. We don't need the credentials to be send to AWS. The changes are made in a way that preserves the current functionality by default.
Testing done
This was tested on our Jenkins instance and is currently active and in production. They work as expected.
The new settings look like this:
Submitter checklist