This repository has been archived by the owner on Dec 1, 2020. It is now read-only.
Typescript conversion #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated all packages - Added typescript to project - Changed major files to Typescript - Converted first file successfully to Typescript One major problem is the overlapping types from DOM and React-Native. DOM is required by Electron, there seems to be no way to fix this.
|
Aah nice! There are a lot of whitespace changes, could you remove those? EDIT: Nvm if the edits are your editor confirming the json's to the |
joshuaboniface
approved these changes
Sep 29, 2019
|
Yeah I think the whitespace changes are the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added typescript to the project, and converted all non-electron source files to typescript. Fixes #25