Skip to content
This repository has been archived by the owner on Dec 1, 2020. It is now read-only.

Suggestion for builds #24

Open
kgraugaard opened this issue Jun 7, 2019 · 6 comments
Open

Suggestion for builds #24

kgraugaard opened this issue Jun 7, 2019 · 6 comments

Comments

@kgraugaard
Copy link

As a suggestion, take a look at https://github.com/pavjacko/renative/

Seems promising for setting up multi-platform build infrastructure.

Have tried it out an could easily build for web and OSX.

@EraYaN
Copy link
Contributor

EraYaN commented Jun 8, 2019

That also uses react-native-web if we were to switch, I would like it it used react-native-dom instead. That way react-native-video is usable.

@DrPandemic
Copy link
Contributor

I would like it it used react-native-dom instead

Since the project is still super small, it's the perfect time for that switch

@skipkayhil
Copy link

Have y'all looked into using Expo? They've made a large push recently into making cross platform apps that work with web, and the expo client app could make deployments really easy for mobile devices

@sudo-tee
Copy link

sudo-tee commented Jun 14, 2019

there seams to have a plugin for react-native-video

https://github.com/pavjacko/renative/tree/master/packages/rnv/pluginTemplates/react-native-video

flexn-io/renative#34

I does look like a promising boilerplate for universal apps

@EraYaN
Copy link
Contributor

EraYaN commented Jun 15, 2019

I don't have that much time to have a look, but our current code should just about drop-in I believe, although I'm not sure how it's redux, redux-thunk, formik support is. And since it seems to generate the package.json for you I'm not sure how to add an extra package.

Also I can't find anything about the UWP platforms (Xbox One). And the Windows platform might or might not be the UWP microsoft project based.

Also they explicitly use react-native-web and react-native-video does not seem to support that so I wonder how they made it work. Did you also test this on the web platform?

@skipkayhil
Copy link

I've used redux and redux-thunk with Expo with no problems, and you can add stuff to package.json and install them like any react project. There's an expo snack on the formik readme, so I think that one should be good too.

I haven't seen anything about Xbox/windows app, so that may end up being a con there.

There's a lot of packages that expo has themselves, they have their own video package https://docs.expo.io/versions/latest/sdk/video/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

5 participants