Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 2 Support #14

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Version 2 Support #14

wants to merge 3 commits into from

Conversation

raul5660
Copy link
Contributor

No description provided.

@jekyc jekyc mentioned this pull request Jun 23, 2015
Open
@jekyc
Copy link
Owner

jekyc commented Jun 23, 2015

Hi raul5660,

Thanks for the pull request and the work put into it.
I've made a general comment in issue #12. In it, I describe that I don't think creating completely separate classes for the python 2 support is easily maintained. I haven't come up with a better solution myself, but until we find a more ideal solution, I'd be glad to link to your fork in both wig and the readme. Would this be temporary "solution" be something you'd be interested in ?

@james-see
Copy link

Can this issue be closed now? Python 3 usage is widespread and there is no reason to maintain a version for 2.x. IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raul5660 @jekyc @james-see