Removing invalid chars #280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ups, not sure why there are 12 commits here, it should be only the last 2. |
|
ah! there are so many commits because @dokterbob manually merged my last PR, so it diverged. let me see if I can fix this |
|
Created this PR again here #281 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the
subscription.namewill contain special characters that cause the outgoing email to fail such as@and,.Such real world example: when name is
'martin@'and email ismartin@email.com, it creates this address for sending'martin@ <martin@email.com>', which fails.I added a filter for these characters:
@,,and;in theget_address(name, email)method.There could be more, these are the real life cases that I faced.
I also considered changing it in the 'cleaning' part of
subscription.saveso that these faulty names don't even go into the database, but I decided to let them in the database and just filter them out when sending. Feel free to put your opinions about this in this PR.